Fix #3621 #3774

Merged

Daksh777 merged 1 commit from master into master

2025-09-05 06:32:15 +00:00

Daksh777 commented

2025-08-22 09:50:53 +00:00

(Migrated from github.com)

This closes #3621

Initially I was trying to use CSS and Mutation Observer to remove the popup and the inset attribute it was adding, but after testing for some days by running from the source code, it turns out the problematic line was this:

/* Blocking annoying elements */
ytmusic-mealbar-promo-renderer {
  display: none !important;
}

It's this popup which it blocks and hence why the UI becomes unreactive:

I don't think there's a need to write extra CSS or a JS script to block the inset attribute because this is a useful popup. And from my last few days of testing, I haven't seen any other annoying popups coming up, so this should be good to go.

However I would also suggest some people to test it and report because ads popups vary from region to region

This closes #3621 Initially I was trying to use CSS and Mutation Observer to remove the popup and the `inset` attribute it was adding, but after testing for some days by running from the source code, it turns out the problematic line was this: ```css /* Blocking annoying elements */ ytmusic-mealbar-promo-renderer { display: none !important; } ``` It's this popup which it blocks and hence why the UI becomes unreactive: <img width="792" height="428" alt="image" src="https://github.com/user-attachments/assets/fb486c39-47d2-489f-9c9d-0e87783d435c" /> I don't think there's a need to write extra CSS or a JS script to block the `inset` attribute because this is a useful popup. And from my last few days of testing, I haven't seen any other annoying popups coming up, so this should be good to go. However I would also suggest some people to test it and report because ads popups vary from region to region

👍 4 🎉 1

copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed

2025-08-23 01:51:36 +00:00

copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull Request Overview

This PR fixes issue #3621 by removing CSS that was blocking YouTube Music promotional popups, which was causing UI responsiveness issues. The problematic CSS rule was hiding ytmusic-mealbar-promo-renderer elements, but this was preventing legitimate and useful popups from appearing and making the interface unresponsive.

Removes CSS rule that blocks mealbar promo renderer elements
Restores normal popup functionality and UI responsiveness

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

## Pull Request Overview This PR fixes issue #3621 by removing CSS that was blocking YouTube Music promotional popups, which was causing UI responsiveness issues. The problematic CSS rule was hiding `ytmusic-mealbar-promo-renderer` elements, but this was preventing legitimate and useful popups from appearing and making the interface unresponsive. - Removes CSS rule that blocks mealbar promo renderer elements - Restores normal popup functionality and UI responsiveness --- <sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/th-ch/youtube-music/new/master/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub>

JellyBrick (Migrated from github.com) approved these changes

2025-09-05 06:31:56 +00:00

No reviewers

JellyBrick

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: YTMD/youtube-music#3774

No description provided.

Rows
Columns