YTMD/youtube-music
1
0
Fork 0
Code Issues 445 Pull requests 34 Projects Releases 87 Packages Wiki Activity Actions

fix: move sendSongInfo to dataloaded event #3766

Closed
franz-dc wants to merge 1 commit from fix/album-play-song-info into master
pull from: fix/album-play-song-info
merge into: YTMD:master
Conversation 1 Commits 1 Files changed 1 +1 -1
franz-dc commented 2025-08-19 18:32:47 +00:00 (Migrated from github.com)
Copy link

Fixes #3733

The event listener callback for videodatachange assumes that dataloaded comes first then dataupdated afterwards.

For songs this is the case. For albums though, it is the reverse, so the song info doesn't get updated as a result. This commit moves the updating of song info on dataloaded instead.

I haven't encountered issues after moving this so far, but if there are unintended side effects, please let me know.

Fixes #3733 The event listener callback for `videodatachange` assumes that `dataloaded` comes first then `dataupdated` afterwards. For songs this is the case. For albums though, it is the reverse, so the song info doesn't get updated as a result. This commit moves the updating of song info on `dataloaded` instead. I haven't encountered issues after moving this so far, but if there are unintended side effects, please let me know.
JellyBrick commented 2025-09-07 04:44:02 +00:00 (Migrated from github.com)
Copy link

fixed by #3659

fixed by #3659

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
awaiting-reply

Awaiting reply

  
breaking changes

   
bug

Something isn't working

  
cannot-reproduce

Bug cannot be reproduced

  
dependencies

Pull requests that update a dependency file

  
documentation

   
duplicate

This issue or pull request already exists

  
electron-issue

It's an Electron or Electron related dependencies issue (not YTM-Desktop issue)

  
enhancement

New feature or request

  
fix-available

A fix to the issue is available in a new version

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
javascript

Pull requests that update javascript code

  
need more information

Need more information about the issue

  
need rebase

This plugin need rebase

  
official-youtube-music-issue

It's an YouTube's issue (not YTM-Desktop issue)

  
plugin request

An issue/discussion requesting for a new plugin or new functionality to an existing plugin.

  
question

Further information is requested

  
release

Release

  
security

   
stale

   
Status: blocked

There are something to do before this

  
typo

   
wontfix

This will not be worked on

  
ytmd-issue

An issue/discussion about ytm desktop, unrelated to th-ch/youtube-music

No labels
awaiting-reply
breaking changes
bug
cannot-reproduce
dependencies
documentation
duplicate
electron-issue
enhancement
fix-available
good first issue
help wanted
invalid
javascript
need more information
need rebase
official-youtube-music-issue
plugin request
question
release
security
stale
Status: blocked
typo
wontfix
ytmd-issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: YTMD/youtube-music#3766
No description provided.
Delete branch "fix/album-play-song-info"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?