YTMD/youtube-music
1
0
Fork 0
Code Issues 445 Pull requests 34 Projects Releases 87 Packages Wiki Activity Actions

Add Material UI 3 component library #3606

Open
arjix wants to merge 33 commits from ArjixWasTaken/mdui into master
pull from: ArjixWasTaken/mdui
merge into: YTMD:master
Conversation 6 Commits 33 Files changed 7 +812 -16
arjix commented 2025-07-12 21:03:56 +00:00
Owner
Copy link

About

This PR does the necessary changes needed in order to use a material 3 component library, specifically mdui.
With Material Design 3 we can easily create beautiful UI on-top of ytmusic, I am mainly working on this as a pre-requisite for #3066 .

Tasks:

  • Make modern LitElements co-exist with old polymer
  • Fix ytmusic icons, they just can't render (magically went away)
  • Fix CSS Conflict between ytmusic and mdui
### About This PR does the necessary changes needed in order to use a material 3 component library, specifically [mdui](https://www.mdui.org/en/). With Material Design 3 we can easily create beautiful UI on-top of ytmusic, I am mainly working on this as a pre-requisite for #3066 . ### Tasks: - [x] Make modern LitElements co-exist with old polymer - [x] ~~Fix ytmusic icons, they just can't render~~ (magically went away) - [x] Fix CSS Conflict between ytmusic and mdui
❤️ 1
arjix commented 2025-07-13 00:11:36 +00:00
Author
Owner
Copy link

Honestly, it might be better if we can somehow transcompile mdui to be in ES5 syntax.
But I don't really know if that would work 🥲

Honestly, it might be better if we can somehow transcompile mdui to be in ES5 syntax. But I don't really know if that would work :smiling_face_with_tear:
arjix commented 2025-08-05 09:34:22 +00:00
Author
Owner
Copy link

Opened this for review, but I am unsure if it's actually ready to get merged.

Opened this for review, but I am unsure if it's actually ready to get merged.
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2025-09-05 19:58:37 +00:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Copy link

Pull Request Overview

This PR integrates the mdui Material Design 3 component library into the YouTube Music desktop application to enable modern UI components on top of the existing interface. The changes focus on making LitElements coexist with the existing Polymer components and resolving CSS conflicts between YouTube Music and mdui.

  • Adds mdui library dependency and initialization
  • Implements CSS conflict resolution through inline styles and script removal
  • Formats existing code for better readability

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/renderer.ts Adds mdui imports and theme setup, reformats querySelector chains
src/preload.ts Implements mdui CSS integration and removes conflicting scripts
patches/mdui.patch Patches mdui for SolidJS compatibility instead of React
package.json Adds mdui dependency and patch configuration
assets/mdui.css Full mdui CSS stylesheet with Material Design 3 tokens
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

## Pull Request Overview This PR integrates the mdui Material Design 3 component library into the YouTube Music desktop application to enable modern UI components on top of the existing interface. The changes focus on making LitElements coexist with the existing Polymer components and resolving CSS conflicts between YouTube Music and mdui. - Adds mdui library dependency and initialization - Implements CSS conflict resolution through inline styles and script removal - Formats existing code for better readability ### Reviewed Changes Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments. <details> <summary>Show a summary per file</summary> | File | Description | | ---- | ----------- | | src/renderer.ts | Adds mdui imports and theme setup, reformats querySelector chains | | src/preload.ts | Implements mdui CSS integration and removes conflicting scripts | | patches/mdui.patch | Patches mdui for SolidJS compatibility instead of React | | package.json | Adds mdui dependency and patch configuration | | assets/mdui.css | Full mdui CSS stylesheet with Material Design 3 tokens | </details> <details> <summary>Files not reviewed (1)</summary> * **pnpm-lock.yaml**: Language not supported </details> --- <sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/th-ch/youtube-music/new/master/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub>
src/preload.ts
@ -8,6 +8,37 @@ import is from 'electron-is';
import * as config from './config';
import mduiStyleSheet from "@assets/mdui.css?inline"
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-09-05 19:58:36 +00:00
Copy link

Missing semicolon at the end of the import statement. Add a semicolon for consistency with the rest of the codebase.

import mduiStyleSheet from "@assets/mdui.css?inline";
Missing semicolon at the end of the import statement. Add a semicolon for consistency with the rest of the codebase. ```suggestion import mduiStyleSheet from "@assets/mdui.css?inline"; ```
src/preload.ts
@ -11,0 +13,4 @@
contextBridge.exposeInMainWorld('litIssuedWarnings', new Set([
"Lit is in dev mode. Not recommended for production! See https://lit.dev/msg/dev-mode for more information.",
"Shadow DOM is being polyfilled via `ShadyDOM` but the `polyfill-support` module has not been loaded. See https://lit.dev/msg/polyfill-support-missing for more information."
]))
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-09-05 19:58:37 +00:00
Copy link

This code suppresses Lit warnings without explanation. Add a comment explaining why these specific warnings are being suppressed and the implications for the application.

This code suppresses Lit warnings without explanation. Add a comment explaining why these specific warnings are being suppressed and the implications for the application.
src/renderer.ts
@ -3,0 +3,4 @@
import 'mdui';
import { setTheme } from 'mdui/functions/setTheme.js';
setTheme('dark')
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-09-05 19:58:36 +00:00
Copy link

Missing semicolon at the end of the statement. Add a semicolon for consistency with the rest of the codebase.

setTheme('dark');
Missing semicolon at the end of the statement. Add a semicolon for consistency with the rest of the codebase. ```suggestion setTheme('dark'); ```
JellyBrick (Migrated from github.com) requested changes 2025-09-05 20:00:20 +00:00
src/renderer.ts
@ -3,0 +3,4 @@
import 'mdui';
import { setTheme } from 'mdui/functions/setTheme.js';
setTheme('dark')
JellyBrick (Migrated from github.com) commented 2025-09-05 19:59:42 +00:00
Copy link

Should setTheme be called here?

Should `setTheme` be called here?
github-actions[bot] (Migrated from github.com) reviewed 2025-09-05 21:41:41 +00:00
src/renderer.ts
@ -3,0 +3,4 @@
import 'mdui';
import { setTheme } from 'mdui/functions/setTheme.js';
setTheme('dark')
github-actions[bot] (Migrated from github.com) commented 2025-09-05 21:41:40 +00:00
Copy link

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ;

setTheme('dark');
🚫 **[eslint]** <[prettier/prettier](https://github.com/prettier/eslint-plugin-prettier#options)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Insert `;` ```suggestion setTheme('dark'); ``` <!-- __reviewdog__:ChAxOTRkYjM2YmIzNWMzOTJlEgZlc2xpbnQ= -->
github-actions[bot] (Migrated from github.com) commented 2025-09-05 21:41:40 +00:00
Copy link

🚫 [eslint] <stylistic/semi> reported by reviewdog 🐶
Missing semicolon.

setTheme('dark');
🚫 **[eslint]** <[stylistic/semi](https://eslint.style/rules/semi)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Missing semicolon. ```suggestion setTheme('dark'); ``` <!-- __reviewdog__:ChA2NDgxMTM4NmUzN2Q0N2M4EgZlc2xpbnQ= -->
src/yt-web-components.d.ts
@ -1,5 +1,6 @@
import type { Icons } from '@/types/icons';
import type { ComponentProps } from 'solid-js';
import { type IntrinsicElements as MDUIElements } from 'mdui/jsx.en';
github-actions[bot] (Migrated from github.com) commented 2025-09-05 21:41:41 +00:00
Copy link

🚫 [eslint] <importPlugin/order> reported by reviewdog 🐶
mdui/jsx.en import should occur before type import of @/types/icons

import { type IntrinsicElements as MDUIElements } from 'mdui/jsx.en';
import type { Icons } from '@/types/icons';
import type { ComponentProps } from 'solid-js';
🚫 **[eslint]** <[importPlugin/order](https://github.com/import-js/eslint-plugin-import/blob/v2.32.0/docs/rules/order.md)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>`mdui/jsx.en` import should occur before type import of `@/types/icons` ```suggestion import { type IntrinsicElements as MDUIElements } from 'mdui/jsx.en'; import type { Icons } from '@/types/icons'; import type { ComponentProps } from 'solid-js'; ``` <!-- __reviewdog__:ChA0N2JjMjk2YTM5NDcwNzVjEgZlc2xpbnQ= -->
github-actions[bot] (Migrated from github.com) reviewed 2025-09-07 04:37:42 +00:00
src/preload.ts
@ -8,6 +8,37 @@ import is from 'electron-is';
import * as config from './config';
import mduiStyleSheet from "@assets/mdui.css?inline"
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:39 +00:00
Copy link

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace "@assets/mdui.css?inline" with '@assets/mdui.css?inline';

import mduiStyleSheet from '@assets/mdui.css?inline';
🚫 **[eslint]** <[prettier/prettier](https://github.com/prettier/eslint-plugin-prettier#options)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Replace `"@assets/mdui.css?inline"` with `'@assets/mdui.css?inline';` ```suggestion import mduiStyleSheet from '@assets/mdui.css?inline'; ``` <!-- __reviewdog__:ChBmMTU4M2NiMjZhNDBmMWUyEgZlc2xpbnQ= -->
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:40 +00:00
Copy link

🚫 [eslint] <stylistic/quotes> reported by reviewdog 🐶
Strings must use singlequote.

import mduiStyleSheet from '@assets/mdui.css?inline'
🚫 **[eslint]** <[stylistic/quotes](https://eslint.style/rules/quotes)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Strings must use singlequote. ```suggestion import mduiStyleSheet from '@assets/mdui.css?inline' ``` <!-- __reviewdog__:ChA0OTA3YzA5MDc5ZDIzZTBmEgZlc2xpbnQ= -->
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:40 +00:00
Copy link

🚫 [eslint] <stylistic/semi> reported by reviewdog 🐶
Missing semicolon.

import mduiStyleSheet from "@assets/mdui.css?inline";
🚫 **[eslint]** <[stylistic/semi](https://eslint.style/rules/semi)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Missing semicolon. ```suggestion import mduiStyleSheet from "@assets/mdui.css?inline"; ``` <!-- __reviewdog__:Cg8yMDI1NGIxYjJhYTIxOTASBmVzbGludA== -->
src/preload.ts
@ -10,1 +10,4 @@
import mduiStyleSheet from "@assets/mdui.css?inline"
contextBridge.exposeInMainWorld('litIssuedWarnings', new Set([
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:40 +00:00
Copy link

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'litIssuedWarnings', with ⏎··'litIssuedWarnings',⏎·

contextBridge.exposeInMainWorld(
  'litIssuedWarnings',
  new Set([
🚫 **[eslint]** <[prettier/prettier](https://github.com/prettier/eslint-plugin-prettier#options)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Replace `'litIssuedWarnings',` with `⏎··'litIssuedWarnings',⏎·` ```suggestion contextBridge.exposeInMainWorld( 'litIssuedWarnings', new Set([ ``` <!-- __reviewdog__:Cg9kOTk4OTg0OTlkM2FiMGISBmVzbGludA== -->
src/preload.ts
@ -11,0 +11,4 @@
import mduiStyleSheet from "@assets/mdui.css?inline"
contextBridge.exposeInMainWorld('litIssuedWarnings', new Set([
"Lit is in dev mode. Not recommended for production! See https://lit.dev/msg/dev-mode for more information.",
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:40 +00:00
Copy link

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace "Lit·is·in·dev·mode.·Not·recommended·for·production!·See·https://lit.dev/msg/dev-mode·for·more·information." with ··'Lit·is·in·dev·mode.·Not·recommended·for·production!·See·https://lit.dev/msg/dev-mode·for·more·information.'

    'Lit is in dev mode. Not recommended for production! See https://lit.dev/msg/dev-mode for more information.',
🚫 **[eslint]** <[prettier/prettier](https://github.com/prettier/eslint-plugin-prettier#options)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Replace `"Lit·is·in·dev·mode.·Not·recommended·for·production!·See·https://lit.dev/msg/dev-mode·for·more·information."` with `··'Lit·is·in·dev·mode.·Not·recommended·for·production!·See·https://lit.dev/msg/dev-mode·for·more·information.'` ```suggestion 'Lit is in dev mode. Not recommended for production! See https://lit.dev/msg/dev-mode for more information.', ``` <!-- __reviewdog__:Cg42NGE4N2ZiMDdkNzdmMBIGZXNsaW50 -->
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:40 +00:00
Copy link

🚫 [eslint] <stylistic/quotes> reported by reviewdog 🐶
Strings must use singlequote.

  'Lit is in dev mode. Not recommended for production! See https://lit.dev/msg/dev-mode for more information.',
🚫 **[eslint]** <[stylistic/quotes](https://eslint.style/rules/quotes)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Strings must use singlequote. ```suggestion 'Lit is in dev mode. Not recommended for production! See https://lit.dev/msg/dev-mode for more information.', ``` <!-- __reviewdog__:ChAyY2I4YWVlMDMzMzA4ZTViEgZlc2xpbnQ= -->
src/preload.ts
@ -11,0 +12,4 @@
contextBridge.exposeInMainWorld('litIssuedWarnings', new Set([
"Lit is in dev mode. Not recommended for production! See https://lit.dev/msg/dev-mode for more information.",
"Shadow DOM is being polyfilled via `ShadyDOM` but the `polyfill-support` module has not been loaded. See https://lit.dev/msg/polyfill-support-missing for more information."
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:40 +00:00
Copy link

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace "Shadow·DOM·is·being·polyfilled·via·ShadyDOM·but·the·polyfill-support·module·has·not·been·loaded.·See·https://lit.dev/msg/polyfill-support-missing·for·more·information." with ··'Shadow·DOM·is·being·polyfilled·via·ShadyDOM·but·the·polyfill-support·module·has·not·been·loaded.·See·https://lit.dev/msg/polyfill-support-missing·for·more·information.',

    'Shadow DOM is being polyfilled via `ShadyDOM` but the `polyfill-support` module has not been loaded. See https://lit.dev/msg/polyfill-support-missing for more information.',
🚫 **[eslint]** <[prettier/prettier](https://github.com/prettier/eslint-plugin-prettier#options)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Replace `"Shadow·DOM·is·being·polyfilled·via·`ShadyDOM`·but·the·`polyfill-support`·module·has·not·been·loaded.·See·https://lit.dev/msg/polyfill-support-missing·for·more·information."` with `··'Shadow·DOM·is·being·polyfilled·via·`ShadyDOM`·but·the·`polyfill-support`·module·has·not·been·loaded.·See·https://lit.dev/msg/polyfill-support-missing·for·more·information.',` ```suggestion 'Shadow DOM is being polyfilled via `ShadyDOM` but the `polyfill-support` module has not been loaded. See https://lit.dev/msg/polyfill-support-missing for more information.', ``` <!-- __reviewdog__:ChA0MzM3OTg5MGFmMTljODk0EgZlc2xpbnQ= -->
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:40 +00:00
Copy link

🚫 [eslint] <stylistic/quotes> reported by reviewdog 🐶
Strings must use singlequote.

  'Shadow DOM is being polyfilled via `ShadyDOM` but the `polyfill-support` module has not been loaded. See https://lit.dev/msg/polyfill-support-missing for more information.'
🚫 **[eslint]** <[stylistic/quotes](https://eslint.style/rules/quotes)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Strings must use singlequote. ```suggestion 'Shadow DOM is being polyfilled via `ShadyDOM` but the `polyfill-support` module has not been loaded. See https://lit.dev/msg/polyfill-support-missing for more information.' ``` <!-- __reviewdog__:ChBkODIzOTBhOWQ5YzdiZWE1EgZlc2xpbnQ= -->
src/preload.ts
@ -11,0 +13,4 @@
contextBridge.exposeInMainWorld('litIssuedWarnings', new Set([
"Lit is in dev mode. Not recommended for production! See https://lit.dev/msg/dev-mode for more information.",
"Shadow DOM is being polyfilled via `ShadyDOM` but the `polyfill-support` module has not been loaded. See https://lit.dev/msg/polyfill-support-missing for more information."
]))
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:40 +00:00
Copy link

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ])) with ··]),⏎);

  ]),
);
🚫 **[eslint]** <[prettier/prettier](https://github.com/prettier/eslint-plugin-prettier#options)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Replace `]))` with `··]),⏎);` ```suggestion ]), ); ``` <!-- __reviewdog__:ChA5YWUyNjA0ZDk2MDllMTNlEgZlc2xpbnQ= -->
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:41 +00:00
Copy link

🚫 [eslint] <stylistic/semi> reported by reviewdog 🐶
Missing semicolon.

]));
🚫 **[eslint]** <[stylistic/semi](https://eslint.style/rules/semi)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Missing semicolon. ```suggestion ])); ``` <!-- __reviewdog__:ChBkMjM3NzZhYTI2Zjg5YWUwEgZlc2xpbnQ= -->
src/renderer.ts
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:41 +00:00
Copy link

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace HTMLElement·&·{·queue:·{·shuffle:·()·=>·void·}·}>( with ⏎········HTMLElement·&·{·queue:·{·shuffle:·()·=>·void·}·}

      .querySelector<
        HTMLElement & { queue: { shuffle: () => void } }
🚫 **[eslint]** <[prettier/prettier](https://github.com/prettier/eslint-plugin-prettier#options)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Replace `HTMLElement·&·{·queue:·{·shuffle:·()·=>·void·}·}>(` with `⏎········HTMLElement·&·{·queue:·{·shuffle:·()·=>·void·}·}` ```suggestion .querySelector< HTMLElement & { queue: { shuffle: () => void } } ``` <!-- __reviewdog__:ChA4MTM4YTE1MjczNzg1OGMxEgZlc2xpbnQ= -->
src/renderer.ts
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:41 +00:00
Copy link

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ··'ytmusic-player-bar',⏎······ with >('ytmusic-player-bar'

      >('ytmusic-player-bar')
🚫 **[eslint]** <[prettier/prettier](https://github.com/prettier/eslint-plugin-prettier#options)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Replace `··'ytmusic-player-bar',⏎······` with `>('ytmusic-player-bar'` ```suggestion >('ytmusic-player-bar') ``` <!-- __reviewdog__:ChBlM2U5MDRkYTZkMTc2MzIyEgZlc2xpbnQ= -->
src/renderer.ts
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:41 +00:00
Copy link

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace HTMLElement·&·{·onRepeatButtonClick:·()·=>·void·}>( with ⏎··········HTMLElement·&·{·onRepeatButtonClick:·()·=>·void·}

        .querySelector<
          HTMLElement & { onRepeatButtonClick: () => void }
🚫 **[eslint]** <[prettier/prettier](https://github.com/prettier/eslint-plugin-prettier#options)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Replace `HTMLElement·&·{·onRepeatButtonClick:·()·=>·void·}>(` with `⏎··········HTMLElement·&·{·onRepeatButtonClick:·()·=>·void·}` ```suggestion .querySelector< HTMLElement & { onRepeatButtonClick: () => void } ``` <!-- __reviewdog__:ChA1MjNjNDNhNjFlZjVjMTAwEgZlc2xpbnQ= -->
src/renderer.ts
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:41 +00:00
Copy link

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ··'ytmusic-player-bar',⏎········ with >('ytmusic-player-bar'

        >('ytmusic-player-bar')
🚫 **[eslint]** <[prettier/prettier](https://github.com/prettier/eslint-plugin-prettier#options)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Replace `··'ytmusic-player-bar',⏎········` with `>('ytmusic-player-bar'` ```suggestion >('ytmusic-player-bar') ``` <!-- __reviewdog__:ChBlMThmNmY4ZGY3ODgxMmE1EgZlc2xpbnQ= -->
src/renderer.ts
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:41 +00:00
Copy link

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace HTMLElement·&·{·updateVolume:·(volume:·number)·=>·void·}>( with ⏎········HTMLElement·&·{·updateVolume:·(volume:·number)·=>·void·}

      .querySelector<
        HTMLElement & { updateVolume: (volume: number) => void }
🚫 **[eslint]** <[prettier/prettier](https://github.com/prettier/eslint-plugin-prettier#options)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Replace `HTMLElement·&·{·updateVolume:·(volume:·number)·=>·void·}>(` with `⏎········HTMLElement·&·{·updateVolume:·(volume:·number)·=>·void·}` ```suggestion .querySelector< HTMLElement & { updateVolume: (volume: number) => void } ``` <!-- __reviewdog__:ChAzNDdhZmUyMzhjOWI0ZmU0EgZlc2xpbnQ= -->
src/renderer.ts
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:41 +00:00
Copy link

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ··'ytmusic-player-bar',⏎······ with >('ytmusic-player-bar'

      >('ytmusic-player-bar')
🚫 **[eslint]** <[prettier/prettier](https://github.com/prettier/eslint-plugin-prettier#options)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Replace `··'ytmusic-player-bar',⏎······` with `>('ytmusic-player-bar'` ```suggestion >('ytmusic-player-bar') ``` <!-- __reviewdog__:ChA3ODUwMzdjMDg3Mzg4OTg0EgZlc2xpbnQ= -->
src/renderer.ts
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:42 +00:00
Copy link

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace HTMLElement·&·{·onVolumeClick:·()·=>·void·}>( with ⏎········HTMLElement·&·{·onVolumeClick:·()·=>·void·}

      .querySelector<
        HTMLElement & { onVolumeClick: () => void }
🚫 **[eslint]** <[prettier/prettier](https://github.com/prettier/eslint-plugin-prettier#options)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Replace `HTMLElement·&·{·onVolumeClick:·()·=>·void·}>(` with `⏎········HTMLElement·&·{·onVolumeClick:·()·=>·void·}` ```suggestion .querySelector< HTMLElement & { onVolumeClick: () => void } ``` <!-- __reviewdog__:ChAxOTZjYjFmM2I1MTU2Y2I0EgZlc2xpbnQ= -->
src/renderer.ts
github-actions[bot] (Migrated from github.com) commented 2025-09-07 04:37:42 +00:00
Copy link

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ··'ytmusic-player-bar',⏎······ with >('ytmusic-player-bar'

      >('ytmusic-player-bar')
🚫 **[eslint]** <[prettier/prettier](https://github.com/prettier/eslint-plugin-prettier#options)> <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br>Replace `··'ytmusic-player-bar',⏎······` with `>('ytmusic-player-bar'` ```suggestion >('ytmusic-player-bar') ``` <!-- __reviewdog__:ChA2MWQ5NTZhYTk3ZTJiYmQyEgZlc2xpbnQ= -->
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin ArjixWasTaken/mdui:ArjixWasTaken/mdui
git switch ArjixWasTaken/mdui

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff ArjixWasTaken/mdui
git switch ArjixWasTaken/mdui
git rebase master
git switch master
git merge --ff-only ArjixWasTaken/mdui
git switch ArjixWasTaken/mdui
git rebase master
git switch master
git merge --no-ff ArjixWasTaken/mdui
git switch master
git merge --squash ArjixWasTaken/mdui
git switch master
git merge --ff-only ArjixWasTaken/mdui
git switch master
git merge ArjixWasTaken/mdui
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
JellyBrick
Labels
Clear labels   
awaiting-reply

Awaiting reply

  
breaking changes

   
bug

Something isn't working

  
cannot-reproduce

Bug cannot be reproduced

  
dependencies

Pull requests that update a dependency file

  
documentation

   
duplicate

This issue or pull request already exists

  
electron-issue

It's an Electron or Electron related dependencies issue (not YTM-Desktop issue)

  
enhancement

New feature or request

  
fix-available

A fix to the issue is available in a new version

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
javascript

Pull requests that update javascript code

  
need more information

Need more information about the issue

  
need rebase

This plugin need rebase

  
official-youtube-music-issue

It's an YouTube's issue (not YTM-Desktop issue)

  
plugin request

An issue/discussion requesting for a new plugin or new functionality to an existing plugin.

  
question

Further information is requested

  
release

Release

  
security

   
stale

   
Status: blocked

There are something to do before this

  
typo

   
wontfix

This will not be worked on

  
ytmd-issue

An issue/discussion about ytm desktop, unrelated to th-ch/youtube-music

No labels
awaiting-reply
breaking changes
bug
cannot-reproduce
dependencies
documentation
duplicate
electron-issue
enhancement
fix-available
good first issue
help wanted
invalid
javascript
need more information
need rebase
official-youtube-music-issue
plugin request
question
release
security
stale
Status: blocked
typo
wontfix
ytmd-issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: YTMD/youtube-music#3606
No description provided.
Delete branch "ArjixWasTaken/mdui"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?