YTMD/youtube-music
1
0
Fork 0
Code Issues 445 Pull requests 34 Projects Releases 87 Packages Wiki Activity Actions

feat: enable the ESM for main #3588

Merged
JellyBrick merged 3 commits from feat/esm into master 2025-07-10 04:43:13 +00:00
Conversation 3 Commits 3 Files changed 5 +14 -24
JellyBrick commented 2025-07-10 04:36:44 +00:00 (Migrated from github.com)
Copy link
No description provided.
MulverineX (Migrated from github.com) reviewed 2025-07-13 20:31:53 +00:00
src/index.ts
@ -78,4 +77,2 @@
process.env.NODE_OPTIONS = '';
// Prevent window being garbage collected
let mainWindow: Electron.BrowserWindow | null;
MulverineX (Migrated from github.com) commented 2025-07-13 20:31:53 +00:00
Copy link

Why was this removed?

Why was this removed?
JellyBrick (Migrated from github.com) reviewed 2025-07-14 10:45:00 +00:00
src/index.ts
@ -78,4 +77,2 @@
process.env.NODE_OPTIONS = '';
// Prevent window being garbage collected
let mainWindow: Electron.BrowserWindow | null;
JellyBrick (Migrated from github.com) commented 2025-07-14 10:45:00 +00:00
Copy link

@MulverineX Are there any regressions caused by this change?

@MulverineX Are there any regressions caused by this change?
MulverineX (Migrated from github.com) reviewed 2025-07-14 21:59:18 +00:00
src/index.ts
@ -78,4 +77,2 @@
process.env.NODE_OPTIONS = '';
// Prevent window being garbage collected
let mainWindow: Electron.BrowserWindow | null;
MulverineX (Migrated from github.com) commented 2025-07-14 21:59:18 +00:00
Copy link

@JellyBrick what I mean is, why was that code there in the first place, and what was the reasoning for removing it? Doesn't this make it a little easier to inject into the app?

@JellyBrick what I mean is, why was that code there in the first place, and what was the reasoning for removing it? Doesn't this make it a little easier to inject into the app?
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
awaiting-reply

Awaiting reply

  
breaking changes

   
bug

Something isn't working

  
cannot-reproduce

Bug cannot be reproduced

  
dependencies

Pull requests that update a dependency file

  
documentation

   
duplicate

This issue or pull request already exists

  
electron-issue

It's an Electron or Electron related dependencies issue (not YTM-Desktop issue)

  
enhancement

New feature or request

  
fix-available

A fix to the issue is available in a new version

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
javascript

Pull requests that update javascript code

  
need more information

Need more information about the issue

  
need rebase

This plugin need rebase

  
official-youtube-music-issue

It's an YouTube's issue (not YTM-Desktop issue)

  
plugin request

An issue/discussion requesting for a new plugin or new functionality to an existing plugin.

  
question

Further information is requested

  
release

Release

  
security

   
stale

   
Status: blocked

There are something to do before this

  
typo

   
wontfix

This will not be worked on

  
ytmd-issue

An issue/discussion about ytm desktop, unrelated to th-ch/youtube-music

No labels
awaiting-reply
breaking changes
bug
cannot-reproduce
dependencies
documentation
duplicate
electron-issue
enhancement
fix-available
good first issue
help wanted
invalid
javascript
need more information
need rebase
official-youtube-music-issue
plugin request
question
release
security
stale
Status: blocked
typo
wontfix
ytmd-issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: YTMD/youtube-music#3588
No description provided.
Delete branch "feat/esm"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?