YTMD/youtube-music
1
0
Fork 0
Code Issues 445 Pull requests 34 Projects Releases 87 Packages Wiki Activity Actions

Update README.md with link to live diagram #3580

Open
JetsettingJames wants to merge 1 commit from JetsettingJames/master into master
pull from: JetsettingJames/master
merge into: YTMD:master
Conversation 5 Commits 1 Files changed 1 +3 -3
JetsettingJames commented 2025-07-08 20:07:27 +00:00 (Migrated from github.com)
Copy link

Adding badge with link to https://repomapr.com/th-ch/youtube-music to help devs understand the repo.
image

Adding badge with link to https://repomapr.com/th-ch/youtube-music to help devs understand the repo. <img width="1492" alt="image" src="https://github.com/user-attachments/assets/0d2d0ff7-9ace-457f-b989-53cd54e8196b" />
arjix commented 2025-07-08 20:40:10 +00:00
Owner
Copy link

As a contributor to this project, I can confidently say that it is highly inaccurate (e.g. it says we use React when we use Solidjs), and honestly it's way more confusing than just reading the README and browsing the code.

Also, the "node"s themselves are defined in what appears to be random classification/order.
It also claims that "youtube-dl" is used in this project, which is blatanly wrong.

As a contributor to this project, I can confidently say that it is highly inaccurate (e.g. it says we use React when we use Solidjs), and honestly it's way more confusing than just reading the README and browsing the code. Also, the "node"s themselves are defined in what appears to be random classification/order. It also claims that "youtube-dl" is used in this project, which is blatanly wrong.
JetsettingJames commented 2025-07-08 20:44:53 +00:00 (Migrated from github.com)
Copy link

@ArjixWasTaken thanks for your constructive feedback. If improved, would you see utility in this product?

@ArjixWasTaken thanks for your constructive feedback. If improved, would you see utility in this product?
arjix commented 2025-07-08 20:47:45 +00:00
Owner
Copy link

Personally? No
I have aphantasia, among other stuff, so I find it easier to just look at the code.

Would be interesting if it generated documentation, akin to readthedocs and had a node-based explorer, where each node is an entry in the documentation.

But the accuracy of the data is important as well.

Personally? No I have aphantasia, among other stuff, so I find it easier to just look at the code. Would be interesting if it generated documentation, akin to [readthedocs](https://about.readthedocs.com/) and had a node-based explorer, where each node is an entry in the documentation. But the accuracy of the data is important as well.
arjix commented 2025-07-08 20:49:35 +00:00
Owner
Copy link

Overall, th-ch/youtube-music is not a library, so AI generated documentation like this seems out of place.
Maybe if it could focus on specific parts (just like you would do on hand-written docs), and not the entire codebase, it would be better.

Overall, th-ch/youtube-music is not a library, so AI generated documentation like this seems out of place. Maybe if it could focus on specific parts (just like you would do on hand-written docs), and not the entire codebase, it would be better.
JetsettingJames commented 2025-07-08 20:55:56 +00:00 (Migrated from github.com)
Copy link

@ArjixWasTaken Thanks. Have indexed accurately other proper libraries, so maybe that. Will iterate and ping once we feel we have something better.

@ArjixWasTaken Thanks. Have indexed accurately other proper libraries, so maybe that. Will iterate and ping once we feel we have something better.
👀 2
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin JetsettingJames/master:JetsettingJames/master
git switch JetsettingJames/master

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff JetsettingJames/master
git switch JetsettingJames/master
git rebase master
git switch master
git merge --ff-only JetsettingJames/master
git switch JetsettingJames/master
git rebase master
git switch master
git merge --no-ff JetsettingJames/master
git switch master
git merge --squash JetsettingJames/master
git switch master
git merge --ff-only JetsettingJames/master
git switch master
git merge JetsettingJames/master
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
awaiting-reply

Awaiting reply

  
breaking changes

   
bug

Something isn't working

  
cannot-reproduce

Bug cannot be reproduced

  
dependencies

Pull requests that update a dependency file

  
documentation

   
duplicate

This issue or pull request already exists

  
electron-issue

It's an Electron or Electron related dependencies issue (not YTM-Desktop issue)

  
enhancement

New feature or request

  
fix-available

A fix to the issue is available in a new version

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
javascript

Pull requests that update javascript code

  
need more information

Need more information about the issue

  
need rebase

This plugin need rebase

  
official-youtube-music-issue

It's an YouTube's issue (not YTM-Desktop issue)

  
plugin request

An issue/discussion requesting for a new plugin or new functionality to an existing plugin.

  
question

Further information is requested

  
release

Release

  
security

   
stale

   
Status: blocked

There are something to do before this

  
typo

   
wontfix

This will not be worked on

  
ytmd-issue

An issue/discussion about ytm desktop, unrelated to th-ch/youtube-music

No labels
awaiting-reply
breaking changes
bug
cannot-reproduce
dependencies
documentation
duplicate
electron-issue
enhancement
fix-available
good first issue
help wanted
invalid
javascript
need more information
need rebase
official-youtube-music-issue
plugin request
question
release
security
stale
Status: blocked
typo
wontfix
ytmd-issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: YTMD/youtube-music#3580
No description provided.
Delete branch "JetsettingJames/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?