Create Duplicate Finder plugin #3401
No reviewers
Labels
No labels
awaiting-reply
breaking changes
bug
cannot-reproduce
dependencies
documentation
duplicate
electron-issue
enhancement
fix-available
good first issue
help wanted
invalid
javascript
need more information
need rebase
official-youtube-music-issue
plugin request
question
release
security
stale
Status: blocked
typo
wontfix
ytmd-issue
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: YTMD/youtube-music#3401
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "patch-2"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -0,0 +174,4 @@
const distance = matrix[normalized2.length][normalized1.length];
const maxLength = Math.max(normalized1.length, normalized2.length);
return Math.round(((maxLength - distance) / maxLength) * 100);
};
we already have a library for string similarity, although it's a different algorithm
@ -0,0 +188,4 @@
const albumEl = element.querySelector('[class*="album"]');
const durationEl = element.querySelector('[class*="duration"]') ||
element.querySelector('time');
You can combine the selectors
Since you made an entire folder for this plugin, might as well split the backend/menu/renderer into separate files instead of having one big
index.ts
file.PS: Please write what your plugin does in the PR's description.
Pull request closed