fix(mpris): keep MPRIS volume in sync with the actual volume #3226

Merged

h-banii merged 1 commit from fix/mpris-sync-volume into master

2025-04-13 05:56:36 +00:00

h-banii commented

2025-04-12 03:46:23 +00:00

(Migrated from github.com)

Fixes #3225 by reverting some of the modifications from 9da0e43

The code introduced in that commit was meant to prevent a supposed recursion described in https://github.com/th-ch/youtube-music/pull/1005#issuecomment-1415717977, but I don't think it happens anymore (at least not in the current codebase, maybe it did in the past)

Now we can call this multiple times and it'll increment the volume properly (+10% volume per call)
playerctl --player=YoutubeMusic volume 0.1+

Before, it would always get the same frozen volume and add 0.1 to it, so it would stop incrementing after the first call.

Fixes #3225 by reverting some of the modifications from 9da0e43 The code introduced in that commit was meant to prevent a supposed recursion described in https://github.com/th-ch/youtube-music/pull/1005#issuecomment-1415717977, but I don't think it happens anymore (at least not in the current codebase, maybe it did in the past) <hr> Now we can call this multiple times and it'll increment the volume properly (+10% volume per call) `playerctl --player=YoutubeMusic volume 0.1+` Before, it would always get the same frozen volume and add 0.1 to it, so it would stop incrementing after the first call.

copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed

2025-04-13 05:56:07 +00:00

copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

JellyBrick commented

2025-04-13 05:56:31 +00:00

(Migrated from github.com)

Thanks!

👍 1

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: YTMD/youtube-music#3226

No description provided.

Rows
Columns