YTMD/youtube-music
1
0
Fork 0
Code Issues 445 Pull requests 34 Projects Releases 87 Packages Wiki Activity Actions

feat: Add initial plugin structure and configuration settings #3166

Closed
vikasyadav01234 wants to merge 1 commit from master into master
pull from: master
merge into: YTMD:master
Conversation 5 Commits 1 Files changed 8 +15325 -19
vikasyadav01234 commented 2025-03-31 09:13:47 +00:00 (Migrated from github.com)
Copy link
No description provided.
Tr07An11 (Migrated from github.com) approved these changes 2025-03-31 12:04:01 +00:00
JellyBrick (Migrated from github.com) requested changes 2025-03-31 13:21:18 +00:00
package.json
@ -144,1 +310,4 @@
"@playwright/test": "1.51.1",
"@stylistic/eslint-plugin-js": "4.2.0",
"@total-typescript/ts-reset": "0.6.1",
"@types/electron": "^1.4.38",
JellyBrick (Migrated from github.com) commented 2025-03-31 13:16:02 +00:00
Copy link

@types/electron is deprecated.
Electron has own type definitions.

`@types/electron` is deprecated. Electron has own type definitions.
src/config/default.d.ts
@ -0,0 +1,23 @@
declare module './default' {
JellyBrick (Migrated from github.com) commented 2025-03-31 13:16:12 +00:00
Copy link

?

?
src/config/default.js
@ -0,0 +1,14 @@
module.exports = {
JellyBrick (Migrated from github.com) commented 2025-03-31 13:16:27 +00:00
Copy link

What is this file?

What is this file?
src/index.ts
@ -40,1 +37,4 @@
import { setUpTray } from 'tray';
import { setupSongInfo } from 'providers/song-info';
import { restart, setupAppControls } from 'providers/app-controls';
import {
JellyBrick (Migrated from github.com) commented 2025-03-31 13:16:38 +00:00
Copy link

Why did you use ./ instead of @/?

Why did you use `./` instead of `@/`?
src/index.ts
@ -369,11 +364,8 @@ async function createMainWindow() {
}),
JellyBrick (Migrated from github.com) commented 2025-03-31 13:18:32 +00:00
Copy link

We don't use oauth. Also, this is not the valid code.

We don't use oauth. Also, this is not the valid code.
src/menu.js
@ -0,0 +1,22 @@
export const MenuTemplate = [
JellyBrick (Migrated from github.com) commented 2025-03-31 13:19:03 +00:00
Copy link

?

?
tsconfig.json
@ -1,14 +1,14 @@
{
"extends": "./node_modules/@electron-toolkit/tsconfig/tsconfig.node.json",
"extends": "./node_modules/@electron-toolkit/tsconfig/tsconfig.node.json", // Updated path
"compilerOptions": {
JellyBrick (Migrated from github.com) commented 2025-03-31 13:21:06 +00:00
Copy link

The standard JSON specification doesn't have “comments”, and this code is not valid.

The standard JSON specification doesn't have “comments”, and this code is not valid.
tsconfig.json
JellyBrick (Migrated from github.com) commented 2025-03-31 13:21:13 +00:00
Copy link

Ditto

Ditto
JellyBrick (Migrated from github.com) requested changes 2025-03-31 13:22:07 +00:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2025-03-31 13:23:18 +00:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Copy link

Pull Request Overview

This PR introduces the initial plugin structure along with configuration settings and basic menu functionality. Key changes include adding plugin utility functions, setting up new menu entries, and enhancing configuration and initialization logic with an added login flow.

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

File Description
src/plugins/utils/main.js Introduces basic plugin and utility functions
src/menu.js Adds new menu template entries for File and Edit menus
src/index.ts Updates import paths and adds a new openBrowserLogin function
src/config/default.js Provides default configuration settings
Files not reviewed (1)
  • package.json: Language not supported
## Pull Request Overview This PR introduces the initial plugin structure along with configuration settings and basic menu functionality. Key changes include adding plugin utility functions, setting up new menu entries, and enhancing configuration and initialization logic with an added login flow. ### Reviewed Changes Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment. | File | Description | | --------------------------- | ------------------------------------------------------------- | | src/plugins/utils/main.js | Introduces basic plugin and utility functions | | src/menu.js | Adds new menu template entries for File and Edit menus | | src/index.ts | Updates import paths and adds a new openBrowserLogin function | | src/config/default.js | Provides default configuration settings | <details> <summary>Files not reviewed (1)</summary> * **package.json**: Language not supported </details>
src/index.ts
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-03-31 13:23:17 +00:00
Copy link

The openBrowserLogin function uses 'shell' and 'ipcMain' without importing them. Please add 'import { shell, ipcMain } from "electron";' at the top of the file to avoid runtime errors.

The openBrowserLogin function uses 'shell' and 'ipcMain' without importing them. Please add 'import { shell, ipcMain } from "electron";' at the top of the file to avoid runtime errors.
JellyBrick commented 2025-03-31 13:25:05 +00:00 (Migrated from github.com)
Copy link

We're sorry, but this PR is suspected to be an AI slop. We can't approve this PR.

We're sorry, but this PR is suspected to be an **AI slop**. We **can't approve** this PR.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Tr07An11
JellyBrick
Labels
Clear labels   
awaiting-reply

Awaiting reply

  
breaking changes

   
bug

Something isn't working

  
cannot-reproduce

Bug cannot be reproduced

  
dependencies

Pull requests that update a dependency file

  
documentation

   
duplicate

This issue or pull request already exists

  
electron-issue

It's an Electron or Electron related dependencies issue (not YTM-Desktop issue)

  
enhancement

New feature or request

  
fix-available

A fix to the issue is available in a new version

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
javascript

Pull requests that update javascript code

  
need more information

Need more information about the issue

  
need rebase

This plugin need rebase

  
official-youtube-music-issue

It's an YouTube's issue (not YTM-Desktop issue)

  
plugin request

An issue/discussion requesting for a new plugin or new functionality to an existing plugin.

  
question

Further information is requested

  
release

Release

  
security

   
stale

   
Status: blocked

There are something to do before this

  
typo

   
wontfix

This will not be worked on

  
ytmd-issue

An issue/discussion about ytm desktop, unrelated to th-ch/youtube-music

No labels
awaiting-reply
breaking changes
bug
cannot-reproduce
dependencies
documentation
duplicate
electron-issue
enhancement
fix-available
good first issue
help wanted
invalid
javascript
need more information
need rebase
official-youtube-music-issue
plugin request
question
release
security
stale
Status: blocked
typo
wontfix
ytmd-issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: YTMD/youtube-music#3166
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?