WIP: feat(plugin): settings-ui #3066
No reviewers
Labels
No labels
awaiting-reply
breaking changes
bug
cannot-reproduce
dependencies
documentation
duplicate
electron-issue
enhancement
fix-available
good first issue
help wanted
invalid
javascript
need more information
need rebase
official-youtube-music-issue
plugin request
question
release
security
stale
Status: blocked
typo
wontfix
ytmd-issue
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: YTMD/youtube-music#3066
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ArjixWasTaken/feat/settings-ui"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Blocked by #3606
About
This is a plugin that introduces a new settings interface!
Configuring everything through menu options is not only a pain, but it is also a pain! (double pain!)
I propose that this plugin is enabled by default, but I won't insist on that if you think otherwise.
TODO
Screenshots
Before I develop this further, I'd like your opinions, any suggestions as to what/how the settings should look like?@th-ch, @JellyBrick, @Su-YongEdit: 2 weeks have passed w/o any message, so I'll continue with whatever I think looks best.
@ -0,0 +1,147 @@import {In Solid.js, you should not use object destructuring on props. If you destructure props, you will lose reactivity.
@ -0,0 +1,147 @@import {Yeah I know, I just don't have reactive values in that specific instance
@ -0,0 +1,147 @@import {ig it is good practice to not destructure the props anywhere, just for the sake of being consistent
Question:
Should the settings:
a) be applied as soon as you change them (like the menu)
b) be applied after pressing a confirm button to close the modal
@JellyBrick, @th-ch
https://github.com/th-ch/youtube-music/pull/3066#issuecomment-2781732433
a) Imo as that's the expected behaviour most users would think of. Also so the users won't be confused as to why their selected settings don't work immediately.
It would be better if a pop up to restart the client is shown with settings that needs a restart to take effect.
PS ignore my suggestion if I (a user) am not qualified or supposed to suggest or share anything here. I just wanted to give my two cents on what I think would be best for the users overall.
@Rairof you didn't understand what I meant, so of course you'd think so
I meant we'd not allow the user to close their settings unless there are no unsaved changes, just like how discord does it
https://github.com/th-ch/youtube-music/pull/3066#issuecomment-2837458315
In that case. my proposal was to automatically apply said user changes inside the settings menu (like how it is now with the in-app menu) with the sole exception being the few plugins/functions that require a restart to function.
a + throttle (e.g. 5sec)
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.