YTMD/youtube-music
1
0
Fork 0
Code Issues 445 Pull requests 34 Projects Releases 87 Packages Wiki Activity Actions

Improve README formatting and enhance adblocker functionality #3016

Closed
peter9811 wants to merge 8 commits from master into master
pull from: master
merge into: YTMD:master
Conversation 9 Commits 8 Files changed 64 +8502 -2948
peter9811 commented 2025-02-22 22:31:00 +00:00 (Migrated from github.com)
Copy link

Update README and changelog formatting, improve TypeScript type annotations, and enhance the functionality of the adblocker plugin.

Update README and changelog formatting, improve TypeScript type annotations, and enhance the functionality of the adblocker plugin.
JellyBrick (Migrated from github.com) reviewed 2025-02-22 22:31:00 +00:00
JellyBrick (Migrated from github.com) requested changes 2025-02-28 14:40:06 +00:00
src/plugins/adblocker/adSpeedup.ts
@ -0,0 +4,4 @@
);
if (skipButton) {
skipButton.click();
}
JellyBrick (Migrated from github.com) commented 2025-02-28 14:39:41 +00:00
Copy link

We don't need void because the type is automatically inferred by typescript.

We don't need void because the type is automatically inferred by typescript.
src/plugins/adblocker/blocker.ts
@ -0,0 +76,4 @@
);
// Set up request blocking and analytics
if (session && blocker) {
JellyBrick (Migrated from github.com) commented 2025-02-28 14:37:46 +00:00
Copy link

ditto

ditto
src/plugins/adblocker/injectors/inject-cliqz-preload.ts
@ -0,0 +1,3 @@
export default async (): Promise<void> => {
JellyBrick (Migrated from github.com) commented 2025-02-28 14:37:06 +00:00
Copy link

This error does not need to be handled here.

This error does not need to be handled here.
tsconfig.json
@ -1,14 +1,20 @@
{
JellyBrick (Migrated from github.com) commented 2025-02-28 14:39:25 +00:00
Copy link

There are no comments in the JSON standard specification, please remove them.

There are no comments in the JSON standard specification, please remove them.
arjix commented 2025-03-06 21:38:11 +00:00
Owner
Copy link

enhance adblocker functionality

I see nothing of the sort, is this meant to be a draft PR?

> enhance adblocker functionality I see nothing of the sort, is this meant to be a [draft](https://github.blog/news-insights/product-news/introducing-draft-pull-requests/) PR?
peter9811 commented 2025-03-06 21:42:25 +00:00 (Migrated from github.com)
Copy link

enhance adblocker functionality

I see nothing of the sort

Probably at the beginning when I was trying to improve some of the procedure on the adblock working way, but apparently wasn't good, so I remove it following the comments

I'll probably have a look later to see if I can do something else

> > enhance adblocker functionality > > I see nothing of the sort Probably at the beginning when I was trying to improve some of the procedure on the adblock working way, but apparently wasn't good, so I remove it following the comments I'll probably have a look later to see if I can do something else
arjix commented 2025-03-06 21:46:46 +00:00
Owner
Copy link

adding a try/catch and simply logging the error does not "enhance" the adblocker's "functionality" in any way,
hence why I asked if this is a draft, because if it is a draft, then we have no reason to review this until you are done

adding a try/catch and simply logging the error does not "enhance" the adblocker's "functionality" in any way, hence why I asked if this is a draft, because if it is a draft, then we have no reason to review this until you are done
👍 1
arjix commented 2025-03-07 00:44:43 +00:00
Owner
Copy link

@peter9811

for UI stuff we usually use solid-js

e.g. https://github.com/th-ch/youtube-music/pull/3066/files

@peter9811 for UI stuff we usually use solid-js e.g. https://github.com/th-ch/youtube-music/pull/3066/files
JellyBrick commented 2025-03-26 14:50:59 +00:00 (Migrated from github.com)
Copy link

Are you asking AI IDEs like Cursor to "improve my code"?

Are you asking AI IDEs like Cursor to "improve my code"?
arjix commented 2025-03-26 15:03:18 +00:00
Owner
Copy link

Holy smokes, 8,503 additions?

Dude, no matter the quality of your PR, changes this big are impossible to review and merge.

If you actually care about contributing, then I recommend splitting up your PR in digestible chunks.

You'll do both yourself and the reviewer a favor :^)

PS: That way even if the reviewer rejects certain parts of your changes, they won't reject all of your changes.

Holy smokes, 8,503 additions? Dude, no matter the quality of your PR, changes this big are impossible to review and merge. If you actually care about contributing, then I recommend splitting up your PR in digestible chunks. You'll do both yourself and the reviewer a favor :^) PS: That way even if the reviewer rejects certain parts of your changes, they won't reject all of your changes.
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2025-03-28 00:35:07 +00:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Copy link

Pull Request Overview

This PR improves the overall formatting of the README and changelog files across multiple languages and updates the ESLint configuration, TypeScript annotations, and adblocker plugin functionality.

  • Updated markdown formatting (e.g., consistent use of single quotes for image captions and standardized section headings) in various README files (ru, ko, is, hu, fr, es, and main README).
  • Improved ESLint configuration formatting for better readability and maintained consistency in GitHub workflows and issue templates.
  • Minor code refactoring changes, such as condition formatting in docs/js/main.js, and enhanced type annotations in the adblocker plugin.

Reviewed Changes

Copilot reviewed 60 out of 64 changed files in this pull request and generated no comments.

Show a summary per file
File Description
eslint.config.mjs Reformatted configuration objects with standardized commas
docs/readme/README-ru.md Updated image quoting and content list to improve readability
docs/readme/README-ko.md Adjusted screenshot quotes and list ordering for consistency
docs/readme/README-is.md Modified image quoting and reordered sections in the table of contents
docs/readme/README-hu.md Refined markdown table and content ordering for clarity
docs/readme/README-fr.md Standardized quotes and content ordering in the demonstration image
docs/readme/README-es.md Adjusted image quotes and reordered sections for consistency
docs/js/main.js Reformatted condition expressions with vertical alignment
changelog.md Updated changelog entry formatting for consistent styling
README.md Modified image quotes, headings, and text blocks for improved clarity
.github/**/.yml and ISSUE_TEMPLATE/.yml Updated string quoting consistency across GitHub workflow and template files
Files not reviewed (4)
  • docs/index.html: Language not supported
  • docs/style/fonts.css: Language not supported
  • docs/style/style.css: Language not supported
  • license: Language not supported
## Pull Request Overview This PR improves the overall formatting of the README and changelog files across multiple languages and updates the ESLint configuration, TypeScript annotations, and adblocker plugin functionality. - Updated markdown formatting (e.g., consistent use of single quotes for image captions and standardized section headings) in various README files (ru, ko, is, hu, fr, es, and main README). - Improved ESLint configuration formatting for better readability and maintained consistency in GitHub workflows and issue templates. - Minor code refactoring changes, such as condition formatting in docs/js/main.js, and enhanced type annotations in the adblocker plugin. ### Reviewed Changes Copilot reviewed 60 out of 64 changed files in this pull request and generated no comments. <details> <summary>Show a summary per file</summary> | File | Description | | -------------------------------------- | ------------------------------------------------------------------- | | eslint.config.mjs | Reformatted configuration objects with standardized commas | | docs/readme/README-ru.md | Updated image quoting and content list to improve readability | | docs/readme/README-ko.md | Adjusted screenshot quotes and list ordering for consistency | | docs/readme/README-is.md | Modified image quoting and reordered sections in the table of contents | | docs/readme/README-hu.md | Refined markdown table and content ordering for clarity | | docs/readme/README-fr.md | Standardized quotes and content ordering in the demonstration image | | docs/readme/README-es.md | Adjusted image quotes and reordered sections for consistency | | docs/js/main.js | Reformatted condition expressions with vertical alignment | | changelog.md | Updated changelog entry formatting for consistent styling | | README.md | Modified image quotes, headings, and text blocks for improved clarity | | .github/**/*.yml and ISSUE_TEMPLATE/*.yml | Updated string quoting consistency across GitHub workflow and template files | </details> <details> <summary>Files not reviewed (4)</summary> * **docs/index.html**: Language not supported * **docs/style/fonts.css**: Language not supported * **docs/style/style.css**: Language not supported * **license**: Language not supported </details>

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
JellyBrick
Labels
Clear labels   
awaiting-reply

Awaiting reply

  
breaking changes

   
bug

Something isn't working

  
cannot-reproduce

Bug cannot be reproduced

  
dependencies

Pull requests that update a dependency file

  
documentation

   
duplicate

This issue or pull request already exists

  
electron-issue

It's an Electron or Electron related dependencies issue (not YTM-Desktop issue)

  
enhancement

New feature or request

  
fix-available

A fix to the issue is available in a new version

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
javascript

Pull requests that update javascript code

  
need more information

Need more information about the issue

  
need rebase

This plugin need rebase

  
official-youtube-music-issue

It's an YouTube's issue (not YTM-Desktop issue)

  
plugin request

An issue/discussion requesting for a new plugin or new functionality to an existing plugin.

  
question

Further information is requested

  
release

Release

  
security

   
stale

   
Status: blocked

There are something to do before this

  
typo

   
wontfix

This will not be worked on

  
ytmd-issue

An issue/discussion about ytm desktop, unrelated to th-ch/youtube-music

No labels
awaiting-reply
breaking changes
bug
cannot-reproduce
dependencies
documentation
duplicate
electron-issue
enhancement
fix-available
good first issue
help wanted
invalid
javascript
need more information
need rebase
official-youtube-music-issue
plugin request
question
release
security
stale
Status: blocked
typo
wontfix
ytmd-issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: YTMD/youtube-music#3016
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?