fix(downloader): use the upgrade button to check for premium status

franz-dc commented

2025-02-16 18:22:10 +00:00

(Migrated from github.com)

Fixes #2985 and also fixes another 304 error when downloading (#2888).

This uses the "Upgrade" button to check for YouTube Music Premium status instead of the "Get Music Premium" button from the account menu. Modified code is based on /src/renderer.ts#L337-L355.

Fixes #2985 and also fixes another 304 error when downloading (#2888). This uses the "Upgrade" button to check for YouTube Music Premium status instead of the "Get Music Premium" button from the account menu. Modified code is based on [/src/renderer.ts#L337-L355](https://github.com/th-ch/youtube-music/blob/573bdfae039a5caa29a45295268bb6a91b7022f1/src/renderer.ts#L337-L355).

JellyBrick commented

2025-02-16 18:41:29 +00:00

(Migrated from github.com)

What happens if the user enabled the "Remove upgrade button" feature?

franz-dc commented

2025-02-16 19:24:54 +00:00

(Migrated from github.com)

What happens if the user enabled the "Remove upgrade button" feature?

It will still find the "Upgrade" button since the remove upgrade button feature only applies a display: none style instead of removing it from the DOM.

> What happens if the user enabled the "Remove upgrade button" feature? It will still find the "Upgrade" button since the remove upgrade button feature only applies a `display: none` style instead of removing it from the DOM.

👍 1

Mendungo commented

2025-02-18 05:46:53 +00:00

(Migrated from github.com)

so do we have to sign in and get youtube premium?

franz-dc commented

2025-02-18 19:19:00 +00:00

(Migrated from github.com)

so do we have to sign in and get youtube premium?

You need to sign in, but you don't need Premium.

> so do we have to sign in and get youtube premium? You need to sign in, but you don't need Premium.

Mendungo commented

2025-02-19 02:06:42 +00:00

(Migrated from github.com)

is signing in a risk for account suspension? i already got suspended once

franz-dc commented

2025-02-19 05:33:35 +00:00

(Migrated from github.com)

is signing in a risk for account suspension? i already got suspended once

Afaik you won't, but if you're really skeptical just make a new, separate one.

Did you get suspended because of using this app?

> is signing in a risk for account suspension? i already got suspended once Afaik you won't, but if you're really skeptical just make a new, separate one. Did you get suspended because of using this app?

Mendungo commented

2025-02-20 02:42:28 +00:00

(Migrated from github.com)

Yes for two days, that's when they put a block on the downloader of the software and the issue appeared

👀 1

Mendungo commented

2025-02-20 03:13:15 +00:00

(Migrated from github.com)

two more things just so ya'll know, if you sign in and don't have premium songs will be downloaded in 128kbs even though it says 256kbs. Also for some reason it only downloads 100 songs if from download playlist selection even though there are 271 songs other than that it works great. Oh forgot to mention downloading playlist is a no go this is the error that pops up

two more things just so ya'll know, if you sign in and don't have premium songs will be downloaded in 128kbs even though it says 256kbs. Also for some reason it only downloads 100 songs if from download playlist selection even though there are 271 songs other than that it works great. Oh forgot to mention downloading playlist is a no go this is the error that pops up ![Screenshot 2025-02-19 215620](https://github.com/user-attachments/assets/5102546c-12f8-4452-ad4c-9b5fa9351ec6)

franz-dc commented

2025-02-20 07:03:35 +00:00

(Migrated from github.com)

two more things just so ya'll know, if you sign in and don't have premium songs will be downloaded in 128kbs even though it says 256kbs. Also for some reason it only downloads 100 songs if from download playlist selection even though there are 271 songs other than that it works great. Oh forgot to mention downloading playlist is a no go this is the error that pops up !

This is related to another issue that still remains unresolved (#1791).

> two more things just so ya'll know, if you sign in and don't have premium songs will be downloaded in 128kbs even though it says 256kbs. Also for some reason it only downloads 100 songs if from download playlist selection even though there are 271 songs other than that it works great. Oh forgot to mention downloading playlist is a no go this is the error that pops up ! This is related to another issue that still remains unresolved (#1791).

Rows
Columns

fix(downloader): use the upgrade button to check for premium status #2987