YTMD/youtube-music
1
0
Fork 0
Code Issues 445 Pull requests 34 Projects Releases 87 Packages Wiki Activity Actions

WIP: Allow Google Signin #508

Closed
WhiteHusky wants to merge 1 commit from linux-useragent-patch-2021-12-2 into master
pull from: linux-useragent-patch-2021-12-2
merge into: YTMD:master
Conversation 7 Commits 1 Files changed 1 +9 -1
WhiteHusky commented 2021-12-02 17:46:42 +00:00 (Migrated from github.com)
Copy link

This doesn't truely fix the problem. A weird combination of refreshing several times and...generally spastastic navigation behavior seems to get around the signin. This is mostly here to show what I tried.

This doesn't truely fix the problem. A weird combination of refreshing several times and...generally spastastic navigation behavior seems to get around the signin. This is mostly here to show what I tried.
👀 2
WhiteHusky commented 2021-12-02 17:47:25 +00:00 (Migrated from github.com)
Copy link

Related to #507

Related to #507
WhiteHusky commented 2021-12-02 17:51:36 +00:00 (Migrated from github.com)
Copy link

Gets weirder:

So after doing the weird navigation dance it kinda...doesn't sign in correctly. It appears if you are, but you get a signed out front page. Removing the patch, signing in, then signing back in by clicking your signed out account it works.

Obviously this is broken.

Gets weirder: So after doing the weird navigation dance it kinda..._doesn't_ sign in correctly. It appears if you are, but you get a signed out front page. Removing the patch, signing in, then signing back in by clicking your signed out account it works. Obviously this is broken.
WhiteHusky commented 2021-12-02 18:27:52 +00:00 (Migrated from github.com)
Copy link

More testing and trying to find a concise path to it working finds it's just a coinflip. Trying going back, forward, and several other navigations seems to be random when it'll just work or not. So I'm stumped.

I also tried just updating the user agent but no dice.

More testing and trying to find a concise path to it working finds it's just a coinflip. Trying going back, forward, and several other navigations seems to be random when it'll just work or not. So I'm stumped. I also tried just updating the user agent but no dice.
Skaifer commented 2021-12-03 18:42:50 +00:00 (Migrated from github.com)
Copy link

Hello!
So I'm facing the same issue on Fedora using appimage. Just in case this info would help, I could not sign in to google account on Vivaldi until I turned on google's crypto token extension in privacy settings.

Cheers!

P.S.
Navigating back two times and forwards two times got me further trough login process. Good workaround, thanks )

Hello! So I'm facing the same issue on Fedora using appimage. Just in case this info would help, I could not sign in to google account on Vivaldi until I turned on google's _**crypto token** extension_ in privacy settings. Cheers! P.S. Navigating back two times and forwards two times got me further trough login process. Good workaround, thanks )
Araxeus commented 2021-12-13 19:16:28 +00:00 (Migrated from github.com)
Copy link

Hey could you try my PR? #515

I think I might have fixed the problem 🙂

Hey could you try my PR? #515 I think I might have fixed the problem 🙂
🚀 1
Araxeus commented 2021-12-30 16:39:32 +00:00 (Migrated from github.com)
Copy link

@WhiteHusky #515 was merged and should have fixed the problem

So this PR could be closed

@WhiteHusky #515 was merged and should have fixed the problem So this PR could be closed
th-ch commented 2022-04-08 13:43:25 +00:00 (Migrated from github.com)
Copy link

Closing as it should be fixed and the PR is stale - feel free to re-open a PR if needed!

Closing as it should be fixed and the PR is stale - feel free to re-open a PR if needed!

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
awaiting-reply

Awaiting reply

  
breaking changes

   
bug

Something isn't working

  
cannot-reproduce

Bug cannot be reproduced

  
dependencies

Pull requests that update a dependency file

  
documentation

   
duplicate

This issue or pull request already exists

  
electron-issue

It's an Electron or Electron related dependencies issue (not YTM-Desktop issue)

  
enhancement

New feature or request

  
fix-available

A fix to the issue is available in a new version

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
javascript

Pull requests that update javascript code

  
need more information

Need more information about the issue

  
need rebase

This plugin need rebase

  
official-youtube-music-issue

It's an YouTube's issue (not YTM-Desktop issue)

  
plugin request

An issue/discussion requesting for a new plugin or new functionality to an existing plugin.

  
question

Further information is requested

  
release

Release

  
security

   
stale

   
Status: blocked

There are something to do before this

  
typo

   
wontfix

This will not be worked on

  
ytmd-issue

An issue/discussion about ytm desktop, unrelated to th-ch/youtube-music

No labels
awaiting-reply
breaking changes
bug
cannot-reproduce
dependencies
documentation
duplicate
electron-issue
enhancement
fix-available
good first issue
help wanted
invalid
javascript
need more information
need rebase
official-youtube-music-issue
plugin request
question
release
security
stale
Status: blocked
typo
wontfix
ytmd-issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: YTMD/youtube-music#508
No description provided.
Delete branch "linux-useragent-patch-2021-12-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?