No adblock before login #55

Closed
opened 2020-11-07 20:25:55 +00:00 by bypequeno · 9 comments
bypequeno commented 2020-11-07 20:25:55 +00:00 (Migrated from github.com)

Hey, I have been using this program with no account and everything worked awesome. Now that I have logged in the adblock seems to not work anymore.

Hey, I have been using this program with no account and everything worked awesome. Now that I have logged in the adblock seems to not work anymore.
th-ch commented 2020-11-09 20:28:13 +00:00 (Migrated from github.com)

Hey @bypequeno, thanks for submitting the issue! Adblock works for me after logging in - can you try disabling/re-enabling the adblock plugin (you will need to restart the app each time) to see if it solves the issue on your side?

Next version will add an option to toggle devtools, for easier debug (in devtools, you can see net::ERR_BLOCKED_BY_CLIENT for blocked requests)

Hey @bypequeno, thanks for submitting the issue! Adblock works for me after logging in - can you try disabling/re-enabling the adblock plugin (you will need to restart the app each time) to see if it solves the issue on your side? Next version will add an option to toggle devtools, for easier debug (in devtools, you can see `net::ERR_BLOCKED_BY_CLIENT` for blocked requests)
bypequeno commented 2020-11-09 21:20:20 +00:00 (Migrated from github.com)

Hey bro, I have discovered that it works when the hide video player plugin is off. When I have it with account and hide video plugin on, the adblock seems to not work properly.

Hey bro, I have discovered that it works when the hide video player plugin is off. When I have it with account and hide video plugin on, the adblock seems to not work properly.
bypequeno commented 2020-11-09 22:04:32 +00:00 (Migrated from github.com)

Now randomly appears some ads, but not as much as without the adblock. The adblocker seems to only work completely without any account logged.
image

Now randomly appears some ads, but not as much as without the adblock. The adblocker seems to only work completely without any account logged. ![image](https://user-images.githubusercontent.com/73602853/98601852-9fc35f80-22ad-11eb-9954-2efbdd4efd46.png)
bypequeno commented 2020-11-25 21:19:40 +00:00 (Migrated from github.com)

I still have the same problem, adblock only works when I don't have an active session also in this latest version. Here you can see what appears to me on the console.
image

I still have the same problem, adblock only works when I don't have an active session also in this latest version. Here you can see what appears to me on the console. ![image](https://user-images.githubusercontent.com/73602853/100282612-f087b900-2f39-11eb-8815-3bcc3907b05d.png)
MikuDroid commented 2020-12-02 18:55:31 +00:00 (Migrated from github.com)

Hey @bypequeno, thanks for submitting the issue! Adblock works for me after logging in - can you try disabling/re-enabling the adblock plugin (you will need to restart the app each time) to see if it solves the issue on your side?

Next version will add an option to toggle devtools, for easier debug (in devtools, you can see net::ERR_BLOCKED_BY_CLIENT for blocked requests)

Same thing happened, just tested. signed with account, ads shows up. Logged out, no ads.

> Hey @bypequeno, thanks for submitting the issue! Adblock works for me after logging in - can you try disabling/re-enabling the adblock plugin (you will need to restart the app each time) to see if it solves the issue on your side? > > Next version will add an option to toggle devtools, for easier debug (in devtools, you can see `net::ERR_BLOCKED_BY_CLIENT` for blocked requests) Same thing happened, just tested. signed with account, ads shows up. Logged out, no ads.
th-ch commented 2020-12-10 18:14:30 +00:00 (Migrated from github.com)

Hey @bypequeno @MikuDroid, v1.7.4 is in pre-release and should fix ad blocking! It seems to work fine for me, free free to give it a try and update this issue accordingly! If you changed adblock settings, you can revert to the default:

"adblocker": {
    "enabled": true,
    "cache": true,
    "disableDefaultLists": false,
    "additionalBlockLists": []
},
Hey @bypequeno @MikuDroid, [v1.7.4](https://github.com/th-ch/youtube-music/releases/tag/v1.7.4) is in pre-release and should fix ad blocking! It seems to work fine for me, free free to give it a try and update this issue accordingly! If you changed adblock settings, you can revert to the default: ```json "adblocker": { "enabled": true, "cache": true, "disableDefaultLists": false, "additionalBlockLists": [] }, ```
MikuDroid commented 2020-12-11 05:57:22 +00:00 (Migrated from github.com)

Hey @bypequeno @MikuDroid, v1.7.4 is in pre-release and should fix ad blocking! It seems to work fine for me, free free to give it a try and update this issue accordingly! If you changed adblock settings, you can revert to the default:

"adblocker": {
    "enabled": true,
    "cache": true,
    "disableDefaultLists": false,
    "additionalBlockLists": []
},

adblocking works on 1.7.4! Thanks!

> > > Hey @bypequeno @MikuDroid, [v1.7.4](https://github.com/th-ch/youtube-music/releases/tag/v1.7.4) is in pre-release and should fix ad blocking! It seems to work fine for me, free free to give it a try and update this issue accordingly! If you changed adblock settings, you can revert to the default: > > ```json > "adblocker": { > "enabled": true, > "cache": true, > "disableDefaultLists": false, > "additionalBlockLists": [] > }, > ``` adblocking works on 1.7.4! Thanks!
bypequeno commented 2020-12-12 14:32:05 +00:00 (Migrated from github.com)

Works pretty well bro, thanks 👍

Works pretty well bro, thanks 👍
bypequeno commented 2020-12-12 14:32:25 +00:00 (Migrated from github.com)

Fixed on 1.7.4

Fixed on 1.7.4
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: YTMD/youtube-music#55
No description provided.