YTMD/youtube-music
1
0
Fork 0
Code Issues 445 Pull requests 34 Projects Releases 87 Packages Wiki Activity Actions

Mpris + obs-tuna fixes #480

Merged
Araxeus merged 8 commits from mpris+tuna-fix into master 2021-12-02 20:03:04 +00:00
Conversation 3 Commits 8 Files changed 7 +144 -72
Araxeus commented 2021-11-10 16:45:56 +00:00 (Migrated from github.com)
Copy link

I've been testing on discord with @JoeJoeTV (many thanks for all the hours invested 😃 ) and we managed to fix all mpris issues (play/pause not working + update progress attribute + seek from mpris + seek to mpris)
should close #372

original comment with mpris bugs: https://github.com/th-ch/youtube-music/issues/65#issuecomment-964235549

docs:
https://www.npmjs.com/package/mpris-service
https://github.com/dbusjs/mpris-service/blob/master/src/index.js#L26-L132
https://github.com/dbusjs/mpris-service/search?q=seeked
https://github.com/dbusjs/mpris-service/blob/master/examples/player.js

For obs-tuna this implements a live update to the progress

also fix #487 by changing status from Playing/Paused to playing/stopped

this pr also adds a songInfo.album for both mpris and tuna (when available, never is available if current song has a video)

ps. mpris could maybe be moved to its own plugin instead of 'camping' inside the shortcuts plugin

I've been testing on discord with @JoeJoeTV (many thanks for all the hours invested 😃 ) and we managed to fix all mpris issues (play/pause not working + update progress attribute + seek *from* mpris + seek *to* mpris) should close #372 original comment with mpris bugs: https://github.com/th-ch/youtube-music/issues/65#issuecomment-964235549 > docs: https://www.npmjs.com/package/mpris-service https://github.com/dbusjs/mpris-service/blob/master/src/index.js#L26-L132 https://github.com/dbusjs/mpris-service/search?q=seeked https://github.com/dbusjs/mpris-service/blob/master/examples/player.js For obs-tuna this implements a live update to the progress also fix #487 by changing status from `Playing`/`Paused` to `playing`/`stopped` this pr also adds a songInfo.album for both mpris and tuna (when available, never is available if current song has a video) > ps. mpris could maybe be moved to its own plugin instead of 'camping' inside the shortcuts plugin
👍 1
mesmerx commented 2021-11-11 22:04:46 +00:00 (Migrated from github.com)
Copy link

great work man, i planning to try add this feature(time update) in this week, i`ll try that ASAP

great work man, i planning to try add this feature(time update) in this week, i`ll try that ASAP
👀 1
mesmerx commented 2021-11-16 17:38:32 +00:00 (Migrated from github.com)
Copy link

as i can test seems to be ok, i`ll try in a clean env just to make sure

as i can test seems to be ok, i`ll try in a clean env just to make sure
th-ch (Migrated from github.com) approved these changes 2021-12-02 20:02:59 +00:00
th-ch (Migrated from github.com) left a comment
Copy link

Looks ok, thanks for the contribution! ✅

Looks ok, thanks for the contribution! ✅
Sign in to join this conversation.
Reviewers
No reviewers
th-ch
Labels
Clear labels   
awaiting-reply

Awaiting reply

  
breaking changes

   
bug

Something isn't working

  
cannot-reproduce

Bug cannot be reproduced

  
dependencies

Pull requests that update a dependency file

  
documentation

   
duplicate

This issue or pull request already exists

  
electron-issue

It's an Electron or Electron related dependencies issue (not YTM-Desktop issue)

  
enhancement

New feature or request

  
fix-available

A fix to the issue is available in a new version

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
javascript

Pull requests that update javascript code

  
need more information

Need more information about the issue

  
need rebase

This plugin need rebase

  
official-youtube-music-issue

It's an YouTube's issue (not YTM-Desktop issue)

  
plugin request

An issue/discussion requesting for a new plugin or new functionality to an existing plugin.

  
question

Further information is requested

  
release

Release

  
security

   
stale

   
Status: blocked

There are something to do before this

  
typo

   
wontfix

This will not be worked on

  
ytmd-issue

An issue/discussion about ytm desktop, unrelated to th-ch/youtube-music

No labels
awaiting-reply
breaking changes
bug
cannot-reproduce
dependencies
documentation
duplicate
electron-issue
enhancement
fix-available
good first issue
help wanted
invalid
javascript
need more information
need rebase
official-youtube-music-issue
plugin request
question
release
security
stale
Status: blocked
typo
wontfix
ytmd-issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: YTMD/youtube-music#480
No description provided.
Delete branch "mpris+tuna-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?