YTMD/youtube-music
1
0
Fork 0
Code Issues 445 Pull requests 34 Projects Releases 87 Packages Wiki Activity Actions

Fix isEnabled for platform-dependent plugins #3883

Open
dima-dencep wants to merge 1 commit from dima-dencep/master into master
pull from: dima-dencep/master
merge into: YTMD:master
Conversation 2 Commits 1 Files changed 1 +1 -1
dima-dencep commented 2025-09-13 12:34:22 +00:00 (Migrated from github.com)
Copy link

This PR fixes #3857 (and possibly other issues)

The issue was that transparent-player is only available for Windows, so it is not exposed in allPlugins()[plugin], and when attempting to obtain .config, an exception occurred that prevented the plugin (album-color-theme) from working correctly.

With this one-character fix (yes, it's strange), everything returned to working order:
image

This PR fixes #3857 (and possibly other issues) The issue was that `transparent-player` is only available for Windows, so it is not exposed in `allPlugins()[plugin]`, and when attempting to obtain `.config`, an exception occurred that prevented the plugin (album-color-theme) from working correctly. With this one-character fix (yes, it's strange), everything returned to working order: <img width="1800" height="1169" alt="image" src="https://github.com/user-attachments/assets/bcc80374-7b1b-4cfb-8b9e-28f4e394dd47" />
arjix commented 2025-09-13 17:47:30 +00:00
Owner
Copy link

ah yes, forgot the ?.

ah yes, forgot the `?.`
arjix approved these changes 2025-09-13 17:47:37 +00:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin dima-dencep/master:dima-dencep/master
git switch dima-dencep/master

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff dima-dencep/master
git switch dima-dencep/master
git rebase master
git switch master
git merge --ff-only dima-dencep/master
git switch dima-dencep/master
git rebase master
git switch master
git merge --no-ff dima-dencep/master
git switch master
git merge --squash dima-dencep/master
git switch master
git merge --ff-only dima-dencep/master
git switch master
git merge dima-dencep/master
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
arjix
Labels
Clear labels   
awaiting-reply

Awaiting reply

  
breaking changes

   
bug

Something isn't working

  
cannot-reproduce

Bug cannot be reproduced

  
dependencies

Pull requests that update a dependency file

  
documentation

   
duplicate

This issue or pull request already exists

  
electron-issue

It's an Electron or Electron related dependencies issue (not YTM-Desktop issue)

  
enhancement

New feature or request

  
fix-available

A fix to the issue is available in a new version

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
javascript

Pull requests that update javascript code

  
need more information

Need more information about the issue

  
need rebase

This plugin need rebase

  
official-youtube-music-issue

It's an YouTube's issue (not YTM-Desktop issue)

  
plugin request

An issue/discussion requesting for a new plugin or new functionality to an existing plugin.

  
question

Further information is requested

  
release

Release

  
security

   
stale

   
Status: blocked

There are something to do before this

  
typo

   
wontfix

This will not be worked on

  
ytmd-issue

An issue/discussion about ytm desktop, unrelated to th-ch/youtube-music

No labels
awaiting-reply
breaking changes
bug
cannot-reproduce
dependencies
documentation
duplicate
electron-issue
enhancement
fix-available
good first issue
help wanted
invalid
javascript
need more information
need rebase
official-youtube-music-issue
plugin request
question
release
security
stale
Status: blocked
typo
wontfix
ytmd-issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: YTMD/youtube-music#3883
No description provided.
Delete branch "dima-dencep/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?