HTTPS Support & Custom Certificates #3647
Labels
No labels
awaiting-reply
breaking changes
bug
cannot-reproduce
dependencies
documentation
duplicate
electron-issue
enhancement
fix-available
good first issue
help wanted
invalid
javascript
need more information
need rebase
official-youtube-music-issue
plugin request
question
release
security
stale
Status: blocked
typo
wontfix
ytmd-issue
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: YTMD/youtube-music#3647
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Preflight Checklist
Problem Description
🚀 Feature Request: HTTPS Support & Custom Certificates
I built a web page that works as a remote control for the app via the REST API.
Right now, it only accepts local origins (
127.0.0.1
,localhost
) or plain HTTP traffic.Proposed Solution
Request:
Please add an option for users to upload their own certificates (
.pem
,.crt
) and enable HTTPS connections.This would allow:
(referencing https://github.com/nglmercer/yt-music-swg)
Thank you!
Alternatives Considered
add documentation to the REST API
Additional Information
No response
Hi there,
I’m interested in working on this issue and have already started prototyping a solution on a separate branch.
Is anyone else currently working on this, or is it okay for me to proceed and open a PR when ready?
If there are any specific requirements or preferences for implementation, please let me know.
Thanks!
@JellyBrick tagging you since you labeled this issue. Please let me know if you have any input or if someone else is already working on it!
I use a proxy on my PC and redirect requests, obviously using an SSL certificate to have the https server and for everything to work correctly.
5️⃣ Dynamic Reverse Proxy
Activation: send the header
X-Proxy-Target: <absolute url>
in any request to the server.X-Proxy-Timeout
30000
).Proxy-Authorization
Authorization
.Example:
code sample
I would like to know how an implementation could be done, since the proxy is only an option, not the solution.
The solution I'm working on is to add an option in the api-server plugin for enabling HTTPS on the server and allowing the user to specify the paths of the certificate and key files to be used on the server.
When this option is enabled by the user, the plugin will restart and then it will create a secure server and pass the certificate and key files to Hono's
serve
method to create a server that can be connected to using HTTPS.I just wanted to check here if anyone else is working on this issue before I open a PR with the code I wrote.