[Feature Request]: Flathub submission #3476
Labels
No labels
awaiting-reply
breaking changes
bug
cannot-reproduce
dependencies
documentation
duplicate
electron-issue
enhancement
fix-available
good first issue
help wanted
invalid
javascript
need more information
need rebase
official-youtube-music-issue
plugin request
question
release
security
stale
Status: blocked
typo
wontfix
ytmd-issue
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: YTMD/youtube-music#3476
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem Description
Right now, we already have access to a Flatpak release of Youtube Music. However, this release format is not really reliable and "user-friendly" as we need to update the flatpak manually on each release.
Proposed Solution
Thus, some people suggested to submit the app to Flathub.
I can be the maintainer of the Flathub submission (it's a quite automatic process to be honest), it doesn't annoy me, even though it would be great if the maintainer could be a "verified" author following the Flathub guidelines. I have already prepared the whole Flatpak manifest, so all we (or I) have to do is to make a PR to the Flathub repo.
Here's the link to my manifest repo if needed:
https://github.com/Skythrew/flathub/tree/youtube-music-th-ch-submission
I have also made a submission request to Flathub.
Related issue: #737
So we've got (as expected) a massive trademark issue with the name and icon as they belong to Google Inc.
Huh, how are so many other apps on flathub that do the same?
Portal For Teams is one example I can think of, it uses the Microsoft teams logo
If we can slap a Linux penguin on top of the yt logo, change the name to smth like "Portal for YTM" and we golden?
And this is not a simple web wrapper, it modifies the website a lot.
I know I know... Indeed, I think if we change the logo and the name it will be accepted, but it would require to also change the tray icon etc... Trademark violations are really found concerning by Flathub nowadays while it wasn't like that in the past, so many apps like the ones you quoted were accepted while they probably wouldn't be today.
Q: Is it common for a flatpak to be manually making sym-links like this?
https://github.com/Skythrew/flathub/blob/youtube-music-th-ch-submission/io.github.th_ch.youtube-music.yml#L84
Sounds out of place, especially since it is a responsibility of the user...
As an Arch linux user (btw), I read the Arch wiki and have already ran such command.
Q: Can the flatpaks we are distributing not be utilized in any way?
e.g. https://github.com/th-ch/youtube-music/releases/download/v3.9.0/YouTube-Music-3.9.0-x86_64.flatpak
If not, shouldn't we update our build system to produce whatever flathub wants?
What is the procedure to this?
Q: Did you use anything from the open PR that adds flatpak support?
https://github.com/th-ch/youtube-music/pull/2047
If not, why?
Actually, yes it is quite common for flatpaks to do that, as without this Discord Rich Presence would not work. I don't see why it should be a user's responsibility. In my opinion, it just makes a feature which is supposed to work be actually working. No one (and especially beginners) should be supposed to know how to handle this. 😄
I'm not sure about this but, reading the guidelines, it seemed that we needed to clearly have a different manifest for Flathub to accept our PR. I think it's quite logical because it's a way for them to be sure we don't push any malicious code to their platform by inspecting the build process.
Of course I used some of the mentioned suggestions there such as the OARS rating. Maybe we should update the application metadata to make it more descriptive about the included features.
+1 Would like to see this on Flathub
https://github.com/flathub/flathub/pull/6627
https://github.com/flathub/flathub/pull/2501
https://github.com/flathub/flathub/issues/6314
I'm not sure why
th-ch/youtube-music
is not allowed, while names likeYTMDesktop
orMS Teams for Linux
are permitted.Should it be
youtube-music-for-desktop
? 🤔@JellyBrick they were more lenient in the past, but they are trying to change that lately
If those same apps were re-submitted today they would probably be turned down, or require a few changes to avoid trademark violations.
We could do what Portal for Teams did, and have a different name specifically for the flatpak builds.
any update on this?