[Bug]: Lyrics aren't centered after the last update #3139
Labels
No labels
awaiting-reply
breaking changes
bug
cannot-reproduce
dependencies
documentation
duplicate
electron-issue
enhancement
fix-available
good first issue
help wanted
invalid
javascript
need more information
need rebase
official-youtube-music-issue
plugin request
question
release
security
stale
Status: blocked
typo
wontfix
ytmd-issue
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: YTMD/youtube-music#3139
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Preflight Checklist
YouTube Music (Application) Version
3.8.0.0
Checklists
What operating system are you using?
Windows
Operating System Version
Windows 11
What CPU architecture are you using?
x64
Last Known Working YouTube Music (Application) version
3.7.0.0
Reproduction steps
The lyrics in the app used to be symmetrical and cenetred, now they are aligned to the left, just open the app.
Expected Behavior
It should be aligned to the center, probably a quick fix.
Actual Behavior
The lyrics are aligned to the left.
Enabled plugins
Lyrics Plugin
Additional Information
No response
bro has the timestamps on 💀
thanks for the report, I'll try to fix this
IMO, them not being centered looks nicer. Would it be possible to make it a config option? I've tried doing it with custom css before with no luck for some reason
bro has bro. They were on by default bro. Bro has bro skull emoji bro.
it's okay if it's added as an option for people who like left alignment, but symmetrical looked nice to me :(
I am an author of that plugin, and I can assure you that they are not on by default.
https://github.com/th-ch/youtube-music/blob/master/src/plugins/synced-lyrics/index.ts#L20
and I am the end user who never clicked any settings in the plugin settings because I might break things and just use them as they are. bro is unaware of bros own plugin
In all commits that have touched that file, the default has always been
false
.9b3cbe8e01/src/plugins/synced-lyrics/index.ts (L20)
8750b54f76/src/plugins/synced-lyrics/index.ts (L20)
533b96d1f6/src/plugins/synced-lyrics/index.ts (L20)
51da259c97/src/plugins/synced-lyrics/index.ts (L20)
4b35a96778/src/plugins/synced-lyrics/index.ts (L20)
And now that I think about it, I don't remember making the lyrics be centered....
PS: Since you chose to insult me, I won't be spending any more time on this ticket, I am not obligated to since I am not a maintainer but a contributor.
@shyney69 The centered lyrics are not intended behavior of this plugin. It was possible to make previously if you had Lyrics Genius plugin enabled. With it disabled, timestamps are also aligned to the left. And also, please, don't insult the contributors and maintainers, they're doing their work for free for your convenience.