[Feature Request] Chromecast support #289

Closed
opened 2021-05-17 22:41:26 +00:00 by playday3008 · 18 comments
playday3008 commented 2021-05-17 22:41:26 +00:00 (Migrated from github.com)

Cast as YouTube Music (as smartphone version)
Or cast as "tab" (as Chrome/Edge etc.)

Cast as YouTube Music (as smartphone version) Or cast as "tab" (as Chrome/Edge etc.)
Araxeus commented 2021-05-17 23:13:57 +00:00 (Migrated from github.com)

I will try working on that, but only if you are prepared to test it out abit when its ready,
because I dont personally have one 😅

I will try working on that, but only if you are prepared to test it out abit when its ready, because I dont personally have one 😅
playday3008 commented 2021-05-18 11:09:51 +00:00 (Migrated from github.com)

No problem

No problem
Araxeus commented 2021-05-18 20:49:37 +00:00 (Migrated from github.com)

@playday3008

Ok here is the first draft version:
https://github.com/Araxeus/youtube-music/tree/chromecast

Its on a branch in my fork. can you clone and run yarn start on it?

run yarn install before launching to install new dependencies

if not, and you are using windows - I can build and upload binaries for you if needed

After enabling the plugin and restarting the app (and allowing electron/youtube-music in firewall), it should theoretically connect to any device it finds - and play there the same music you play in the app

@playday3008 Ok here is the first draft version: https://github.com/Araxeus/youtube-music/tree/chromecast Its on a branch in my fork. can you clone and run `yarn start` on it? > run `yarn install` before launching to install new dependencies if not, and you are using windows - I can build and upload binaries for you if needed After enabling the plugin and restarting the app (and allowing electron/youtube-music in firewall), it should theoretically connect to any device it finds - and play there the same music you play in the app
playday3008 commented 2021-05-18 21:32:32 +00:00 (Migrated from github.com)

if not, and you are using windows - I can build and upload binaries for you if needed

You can set up GitHub Actions or build it for me, bcoz im on Windows

> if not, and you are using windows - I can build and upload binaries for you if needed You can set up GitHub Actions or build it for me, bcoz im on Windows
Araxeus commented 2021-05-18 21:44:32 +00:00 (Migrated from github.com)
Here you go https://drive.google.com/drive/folders/1Kfa4USQtoUjZTZLzgToDM6kMELdkRqgC?usp=sharing
playday3008 commented 2021-05-18 21:57:52 +00:00 (Migrated from github.com)

Not working @Araxeus

Not working @Araxeus
Araxeus commented 2021-05-18 22:21:54 +00:00 (Migrated from github.com)

I have uploaded a new version (same gdrive folder)

I added a message box with current status (since you cant see console output)

Also The first button in 'Plugins' menu should be now 'Update Chromecast List'

can you download again and try updating and see what the message box output looks like?

I have uploaded a new version (same gdrive folder) I added a message box with current status (since you cant see console output) Also The first button in 'Plugins' menu should be now 'Update Chromecast List' can you download again and try updating and see what the message box output looks like?
playday3008 commented 2021-05-18 22:54:37 +00:00 (Migrated from github.com)

Well, device found
image
But search output incorrect
image

P.S. Maybe you have Telegram to contact?

Well, device found ![image](https://user-images.githubusercontent.com/18056374/118733431-868f0300-b83c-11eb-80b1-ceb322445d2f.png) But search output incorrect ![image](https://user-images.githubusercontent.com/18056374/118733484-a1617780-b83c-11eb-97fe-2c5f3e8dfb3f.png) P.S. Maybe you have Telegram to contact?
Araxeus commented 2021-05-18 23:16:49 +00:00 (Migrated from github.com)

I've fixed that toString, and added more checks. you can download from folder again 😝

Does only find the device after clicking the Update button in the menu? or before?
Does it say anything when playing songs / pausing songs?

By the way try to register device only once, because there isn't currently any check for duplication (it adds device every time you find one)

Telegram Username @Oksidoxi

I've fixed that toString, and added more checks. you can download from [folder](https://drive.google.com/drive/folders/1Kfa4USQtoUjZTZLzgToDM6kMELdkRqgC?usp=sharing) again 😝 Does only find the device after clicking the Update button in the menu? or before? Does it say anything when playing songs / pausing songs? By the way try to register device only once, because there isn't currently any check for duplication (it adds device every time you find one) > Telegram Username [@Oksidoxi](https://t.me/Oksidoxi)
BelgarionNL commented 2021-06-23 14:39:09 +00:00 (Migrated from github.com)

so how do you cast. I have the latest version in windows and I dont see the plugin.

so how do you cast. I have the latest version in windows and I dont see the plugin.
Araxeus commented 2021-06-23 19:56:25 +00:00 (Migrated from github.com)

@BelgarionNL it hasn't been released yet (there is an open pull request)

Love your username BTW, is it from the Belgariad/Malloreon or just random? :P

@BelgarionNL it hasn't been released yet (there is an open pull request) Love your username BTW, is it from the Belgariad/Malloreon or just random? :P
BelgarionNL commented 2021-06-25 00:40:05 +00:00 (Migrated from github.com)

yea its from the belgariad ofcourse :)

yea its from the belgariad ofcourse :)
kultawat commented 2021-07-18 03:31:52 +00:00 (Migrated from github.com)

How can I test this on mac?

How can I test this on mac?
btTeddy commented 2021-11-22 23:58:51 +00:00 (Migrated from github.com)

@Araxeus
Hi
Is there any update on cast functionality?

I can se cast icon on latest 1.14.0 but clicking it really does completely nothing.
image

Tried 1.12.1 from your gdrive but I don't see in there any option to cast at all

@Araxeus Hi Is there any update on cast functionality? I can se cast icon on latest 1.14.0 but clicking it really does completely nothing. ![image](https://user-images.githubusercontent.com/91010735/142952511-37e7bccb-b410-4a97-aab5-2f0d2bc994fb.png) Tried 1.12.1 from your gdrive but I don't see in there any option to cast at all
cmcinroy commented 2021-12-07 16:30:46 +00:00 (Migrated from github.com)

@Beersteddy I just noticed the same icon. Turns out it's from the underlying Youtube Music service. Presumably, the reason it does nothing in this app is that in a browser it brings up the menu to select the target cast device.

It would be interesting to know whether this new feature in the base service gets us any closer to casting from an electron app.

@Beersteddy I just noticed the same icon. Turns out it's from the underlying Youtube Music service. Presumably, the reason it does nothing in this app is that in a browser it brings up the menu to select the target cast device. It would be interesting to know whether this new feature in the base service gets us any closer to casting from an electron app.
Araxeus commented 2021-12-07 16:33:38 +00:00 (Migrated from github.com)

It would be interesting to know whether this new feature in the base service gets us any closer to casting from an electron app.

No it sadly doesn't, their internal implementation doesn't work because electron doesn't support[1][2] the chrome.cast api

#509 will remove this button since it doesn't work.

PR #296 could be re-opened in the future (it mostly works)

> It would be interesting to know whether this new feature in the base service gets us any closer to casting from an electron app. No it sadly doesn't, their internal implementation doesn't work because electron doesn't support[[1](https://github.com/electron/electron/issues/869)][[2](https://github.com/electron/electron/issues/7024)] the `chrome.cast` api #509 will remove this button since it doesn't work. PR #296 could be re-opened in the future (it mostly works)
Araxeus commented 2021-12-07 16:35:50 +00:00 (Migrated from github.com)

@Beersteddy

Tried 1.12.1 from your gdrive but I don't see in there any option to cast at all

Thats because you would need to clone the branch from the Pull Request to test the latest changes (gdrive was a very early alpha version)

Might have other bugs since its based on an old version of the app

@Beersteddy > Tried 1.12.1 from your gdrive but I don't see in there any option to cast at all Thats because you would need to clone the [branch](https://github.com/Araxeus/youtube-music/tree/chromecast) from the [Pull Request](https://github.com/th-ch/youtube-music/pull/296) to test the latest changes (gdrive was a very early alpha version) Might have other bugs since its based on an old version of the app
JellyBrick commented 2023-10-07 09:19:12 +00:00 (Migrated from github.com)

Duplicate of #113

Duplicate of #113
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: YTMD/youtube-music#289
No description provided.